Move agent management into profile sidebar#1200
Conversation
klopez4212
force-pushed
the
kennylopez-agent-profile-sidebar
branch
from
37d03e8 to
309889d
Compare
klopez4212
force-pushed
the
kennylopez-agents-page-cards
branch
from
9b87d11 to
60822a4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 309889d000
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -196,15 +259,40 @@ export function UserProfilePanel({ | |||
| ); | |||
| useActiveAgentTurnsBridge(bridgeAgents); | |||
| useManagedAgentObserverBridge(bridgeAgents); | |||
There was a problem hiding this comment.
When this panel opens or switches targets, this per-profile bridge runs with bridgeAgents set to either a single managed agent or [] for non-managed profiles. useManagedAgentObserverBridge clears the module-level knownAgentPubkeys before adding its argument, while the Agents and Channel screens also call the same bridge for all active agents, so opening a profile can replace the trusted set and cause observer telemetry from every other agent to be ignored until another full-list bridge reruns. This breaks working badges/activity for other agents while a profile panel is open; the profile panel should not clear the global registration or the bridge should merge registrations across callers.
Useful? React with 👍 / 👎.
| diagnosticsSummary={diagnosticsSummary} | ||
| modelLabel={modelLabel} | ||
| onOpenAgentInfo={() => setView("info")} | ||
| onOpenAgentSettings={() => setView("settings")} |
There was a problem hiding this comment.
In ChannelPane and Pulse this panel is controlled by profilePanelView, but their URL-state parsers still preserve only memories and channels. Clicking this new Settings ingress writes profileView=settings through onViewChange, then the next render coerces it back to summary, so Settings (and the other new subviews wired here) cannot be opened outside the unmanaged Agents page. Please update the controlled profile view parsing to accept all ProfilePanelView values before emitting these new views.
Useful? React with 👍 / 👎.
tellaho
force-pushed
the
kennylopez-agent-profile-sidebar
branch
from
c004018 to
309889d
Compare
1 participant
Summary
Notes
Validation
cd desktop && pnpm checkcd desktop && pnpm typecheck